Don't fail send_all retaining reserves for 0 channels
#540
+93
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previouly, `OnchainPayment::send_all_to_address` would fail in the `retain_reserves` mode if the maintained reserves were below the dust limit. Most notably this would happen if we had no channels open at all. Here, we fix this by simply falling back to the draining case (not considering reserves) if the anchor reserves are below dust. We also add a unit test that would have caught this regression in the first place.
|
👋 Thanks for assigning @jkczyz as a reviewer! |
|
🔔 1st Reminder Hey @jkczyz! This PR has been waiting for your review. |
jkczyz
reviewed
May 19, 2025
.. as this is useful information.
We create temporary transactions for fee estimation purposes. Doing this might advance the descriptor state though. So here we call `cancel_tx` to tell the wallet we no longer intend to broadcast the temporary transactions.
tnull
force-pushed
the
2025-05-fix-sendall-retaining-reserve-for-dust
branch
from
0c027cf to
1e5f4a2
Compare
m1sterc001guy
approved these changes
May 20, 2025
jkczyz
reviewed
May 20, 2025
Squashed with the following additional changes: > git diff-tree -U2 1e5f4a27 dc2902af
diff --git a/tests/integration_tests_rust.rs b/tests/integration_tests_rust.rs
index 1d33a14c..fde56620 100644
--- a/tests/integration_tests_rust.rs
+++ b/tests/integration_tests_rust.rs
@@ -530,4 +530,5 @@ fn onchain_send_all_retains_reserve() {
node_a.sync_wallets().unwrap();
node_b.sync_wallets().unwrap();
+ // Check node a sent all and node b received it
assert_eq!(node_a.list_balances().spendable_onchain_balance_sats, 0);
assert!(((premine_amount_sat * 2 - onchain_fee_buffer_sat)..=(premine_amount_sat * 2))
@@ -556,4 +557,5 @@ fn onchain_send_all_retains_reserve() {
expect_channel_ready_event!(node_b, node_a.node_id());
+ // Check node a sent all and node b received it
assert_eq!(node_a.list_balances().spendable_onchain_balance_sats, 0);
assert!(((premine_amount_sat - reserve_amount_sat - onchain_fee_buffer_sat)
@@ -570,4 +572,5 @@ fn onchain_send_all_retains_reserve() {
node_b.sync_wallets().unwrap();
+ // Check node b sent all and node a received it
assert_eq!(node_b.list_balances().total_onchain_balance_sats, reserve_amount_sat);
assert_eq!(node_b.list_balances().spendable_onchain_balance_sats, 0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #539.
Previouly,
OnchainPayment::send_all_to_addresswould fail in theretain_reservesmode if the maintained reserves were below the dustlimit. Most notably this would happen if we had no channels open at all.
Here, we fix this by simply falling back to the draining case (not
considering reserves) if the anchor reserves are below dust. We also add
a unit test that would have caught this regression in the first place.
Note: Github diff really messes up the first commit which is mostly adding an
ifand re-indenting the previous codeblock. It's best reviewed withgit show --color-moved --ignore-all-space